Re: [PATCH resend] dt-bindings: mfd: mediatek: Add bindings for MT6360 PMIC

[Vaittinen, Matti]

Hello Peeps,

On Thu, 2020-12-24 at 11:19 +0800, Gene Chen wrote:
> From: Gene Chen <gene_chen@xxxxxxxxxxx>
> 
> Add bindings for MT6360 PMIC
> 
> Signed-off-by: Gene Chen <gene_chen@xxxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/mfd/mt6360.yaml | 69
> +++++++++++++++++++++++
>  1 file changed, 69 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mfd/mt6360.yaml
> 
> diff --git a/Documentation/devicetree/bindings/mfd/mt6360.yaml
> b/Documentation/devicetree/bindings/mfd/mt6360.yaml
> new file mode 100644
> index 0000000..2781c31
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/mt6360.yaml
> @@ -0,0 +1,69 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/mt6360.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MT6360 PMIC from MediaTek Integrated
> +
> +maintainers:
> +  - Gene Chen <gene_chen@xxxxxxxxxxx>
> +
> +description: |
> +  MT6360 is a PMIC device with the following sub modules.
> +  It is interfaced to host controller using I2C interface.
> +
> +  This document describes the binding for PMIC device and its sub
> module.
> +
> +properties:
> +  compatible:
> +    const: mediatek,mt6360
> +
> +  reg:
> +    description:
> +      I2C device address.
> +    maxItems: 1
> +
> +  wakeup-source: true
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  interrupt-names:
> +      enum:
> +        - IRQB
> +
> +  interrupt-controller: true
> +
> +  "#interrupt-cells":
> +    const: 1
> +    description:
> +      The first cell is the IRQ number.
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - interrupt-controller
> +  - "#interrupt-cells"
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    #include <dt-bindings/regulator/mediatek,mt6360-regulator.h>
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        mt6360@34 {
> +            compatible = "mediatek,mt6360";
> +            reg = <0x34>;
> +            wakeup-source;
> +            interrupts-extended = <&gpio26 0 IRQ_TYPE_LEVEL_LOW>;
> +            interrupt-names = "IRQB";
> +            interrupt-controller;
> +            #interrupt-cells = <1>;

Out of the curiosity - is this the complete node? I would assume some
sub-devices like regulators here?

> +        };
> +    };