Re: [PATCH] scsi: ufs: should not override buffer lengh

From: Can Guo
Date: Mon Jan 11 2021 - 03:20:24 EST


On 2021-01-11 16:15, Avri Altman wrote:

Sorry, typo corrected.

Hi Jaegeuk,

I think the problem is that func ufshcd_read_desc_param() is not
expecting
one access unsupported descriptors on RPMB LU.
Correct.
This is about wb introducing a new constraint: wb buffer is only
allowed in lu 0..7.
And this is why, IMHO, the fix should be in ufs_is_valid_unit_desc_lun,
To include param offset, as it is only called in contingency of
ufshcd_read_desc_param.

Thanks,
Avri

Yeah... Fixing it in ufs-sysfs.c also works. Anyways, the math in
ufshcd_read_desc_param is already complex. Let's fix it somewhere
close to the source/initiator.

Thanks,
Can Guo.