Re: [PATCH] usb/gadget: f_midi: Replace tasklet with work

[Felipe Balbi]

Hi,

Davidlohr Bueso <dave@xxxxxxxxxxxx> writes:
> Currently a tasklet is used to transmit input substream buffer
> data. However, tasklets have long been deprecated as being too
> heavy on the system by running in irq context - and this is not
> a performance critical path. If a higher priority process wants
> to run, it must wait for the tasklet to finish before doing so.
>
> Deferring work to a workqueue and executing in process context
> should be fine considering the callback already does
> f_midi_do_transmit() under the transmit_lock and thus changes in
> semantics are ok regarding concurrency - tasklets being serialized
> against itself.
>
> Cc: Takashi Iwai <tiwai@xxxxxxx>
> Signed-off-by: Davidlohr Bueso <dbueso@xxxxxxx>

Acked-by: Felipe Balbi <balbi@xxxxxxxxxx>

-- 
balbi

Attachment: signature.asc
Description: PGP signature