Re: [PATCH 2/5] Input: omap4-keypad - scan keys in two phases and simplify with bitmask

From: Dmitry Torokhov
Date: Mon Jan 11 2021 - 01:27:14 EST


On Mon, Jan 11, 2021 at 07:56:54AM +0200, Tony Lindgren wrote:
> * Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> [210111 04:48]:
> > Technically speaking, userspace is free to accumulate the events until
> > it receives EV_SYN/SYN_REPORT event and process the events in the event
> > packet in order it sees fit. So to achieve what you want, I think we
> > should issue 2 input_sync()s, one for the release block, and another is
> > for press. I think we can also simplify the code if we pass into the new
> > scan function exact set of keys that are being released or pressed.
> >
> > How about the version below?
>
> Yes that works nicely.

Excellent, applied, thank you.

--
Dmitry