Re: [PATCH v2] proc_sysctl: fix oops caused by incorrect command parameters.

From: Xiaoming Ni
Date: Sun Jan 10 2021 - 22:15:16 EST


On 2021/1/9 17:10, Andy Shevchenko wrote:


On Friday, January 8, 2021, Xiaoming Ni <nixiaoming@xxxxxxxxxx <mailto:nixiaoming@xxxxxxxxxx>> wrote:

The process_sysctl_arg() does not check whether val is empty before
 invoking strlen(val). If the command line parameter () is incorrectly
 configured and val is empty, oops is triggered.

For example, "hung_task_panic=1" is incorrectly written as
"hung_task_panic".

log:


Can you drop redundant (not significant) lines from the log to avoid noisy commit message?

ok,
Thank you for your advice.
I will update it in v3 patch.

Thanks

Xiaoming Ni.