Re: [PATCH] clk: imx: fix Kconfig warning for i.MX SCU clk

From: Shawn Guo
Date: Sun Jan 10 2021 - 20:41:59 EST


On Wed, Dec 30, 2020 at 04:52:25PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> A previous patch introduced a harmless randconfig warning:
>
> WARNING: unmet direct dependencies detected for MXC_CLK_SCU
> Depends on [n]: COMMON_CLK [=y] && ARCH_MXC [=n] && IMX_SCU [=y] && HAVE_ARM_SMCCC [=y]
> Selected by [m]:
> - CLK_IMX8QXP [=m] && COMMON_CLK [=y] && (ARCH_MXC [=n] && ARM64 [=y] || COMPILE_TEST [=y]) && IMX_SCU [=y] && HAVE_ARM_SMCCC [=y]
>
> Since the symbol is now hidden and only selected by other symbols,
> just remove the dependencies and require the other drivers to
> get it right.
>
> Fixes: 6247e31b7530 ("clk: imx: scu: fix MXC_CLK_SCU module build break")
> Reported-by: Anders Roxell <anders.roxell@xxxxxxxxxx>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Looks good to me.

Stephen, I assume that you will pick it up as a material for 5.11-rc.

Shawn