On Fri, Jan 8, 2021 at 1:36 PM Radhey Shyam Pandey <radheys@xxxxxxxxxx> wrote:
OK, I think I need to revisit this and clean it up some. Currently In-----Original Message-----Yes, please also share the dmaclient DT client node. Need to see
From: Paul Thomas <pthomas8589@xxxxxxxxx>
Sent: Friday, January 8, 2021 9:27 PM
To: Radhey Shyam Pandey <radheys@xxxxxxxxxx>
Cc: Dan Williams <dan.j.williams@xxxxxxxxx>; Vinod Koul
<vkoul@xxxxxxxxxx>; Michal Simek <michals@xxxxxxxxxx>; Matthew Murrian
<matthew.murrian@xxxxxxxxxx>; Romain Perier
<romain.perier@xxxxxxxxx>; Krzysztof Kozlowski <krzk@xxxxxxxxxx>; Marc
Ferland <ferlandm@xxxxxxxxx>; Sebastian von Ohr
<vonohr@xxxxxxxxxxx>; dmaengine@xxxxxxxxxxxxxxx; Linux ARM <linux-
arm-kernel@xxxxxxxxxxxxxxxxxxx>; linux-kernel <linux-
kernel@xxxxxxxxxxxxxxx>; dave.jiang@xxxxxxxxx; Shravya Kumbham
<shravyak@xxxxxxxxxx>; git <git@xxxxxxxxxx>
Subject: Re: dmaengine : xilinx_dma two issues
Hi All,
On Fri, Jan 8, 2021 at 2:13 AM Radhey Shyam Pandey <radheys@xxxxxxxxxx>
wrote:
Is this a question for me?-----Original Message-----
From: Radhey Shyam Pandey
Sent: Monday, January 4, 2021 10:50 AM
To: Paul Thomas <pthomas8589@xxxxxxxxx>; Dan Williams
<dan.j.williams@xxxxxxxxx>; Vinod Koul <vkoul@xxxxxxxxxx>; Michal
Simek <michals@xxxxxxxxxx>; Matthew Murrian
<matthew.murrian@xxxxxxxxxx>; Romain Perier
<romain.perier@xxxxxxxxx>; Krzysztof Kozlowski <krzk@xxxxxxxxxx>;
Marc Ferland <ferlandm@xxxxxxxxx>; Sebastian von Ohr
<vonohr@xxxxxxxxxxx>; dmaengine@xxxxxxxxxxxxxxx; Linux ARM <linux-
arm-kernel@xxxxxxxxxxxxxxxxxxx>; linux-kernel <linux-
kernel@xxxxxxxxxxxxxxx>; Shravya Kumbham <shravyak@xxxxxxxxxx>; git
<git@xxxxxxxxxx>
Subject: RE: dmaengine : xilinx_dma two issues
-----Original Message-----<romain.perier@xxxxxxxxx>;
From: Paul Thomas <pthomas8589@xxxxxxxxx>
Sent: Monday, December 28, 2020 10:14 AM
To: Dan Williams <dan.j.williams@xxxxxxxxx>; Vinod Koul
<vkoul@xxxxxxxxxx>; Michal Simek <michals@xxxxxxxxxx>; Radhey
Shyam Pandey <radheys@xxxxxxxxxx>; Matthew Murrian
<matthew.murrian@xxxxxxxxxx>; Romain Perier
Krzysztof Kozlowski <krzk@xxxxxxxxxx>; Marc Ferland+ (Xilinx mailing list)
<ferlandm@xxxxxxxxx>; Sebastian von Ohr <vonohr@xxxxxxxxxxx>;
dmaengine@xxxxxxxxxxxxxxx; Linux ARM <linux-
arm-kernel@xxxxxxxxxxxxxxxxxxx>; linux-kernel <linux-
kernel@xxxxxxxxxxxxxxx>
Subject: dmaengine : xilinx_dma two issues
Hello,
I'm trying to get the 5.10 kernel up and running for our system,
and I'm running into a couple of issues with xilinx_dma.
Thanks for bringing the issues to our notice. Replies inline.
First, commit 14ccf0aab46e 'dmaengine: xilinx_dma: In dma channelcall to:
probe fix node order dependency' breaks our usage. Before this
commit a
dma_request_chan(&indio_dev->dev, "axi_dma_0"); returns fine, butxilinx_dma_chan_probe()).
after that commit it returns -19. The reason for this seems to be
that the only channel that is setup is channel 1 (chan->id is 1 in
However inWhat is the channel number passed in dmaclient DT?
of_dma_xilinx_xlate() chan_id is gets set to 0 (int chan_id =
dma_spec-
args[0];), which causes the:!xdev->chan[chan_id]
test to fail in of_dma_xilinx_xlate()
channel number passed to dmas property. Something like below-
dmas = <& axi_dma_0 1>
dma-names = "axi_dma_0"
the driver (a custom iio adc driver) it is hard coded:
dma_request_chan(&indio_dev->dev, "axi_dma_0");
However, the DT also has the entries (currently unused by the driver):
dmas = <&axi_dma_0 0>;
dma-names = "axi_dma_0";
I'll go back and clean up our driver to do something like adi-axi-adc.c does:
if (!device_property_present(dev, "dmas"))
return 0;
if (device_property_read_string(dev, "dma-names", &dma_name))
dma_name = "axi_dma_0";
Should the dmas node get used by the driver? I see the second argument
is: '0' for write/tx and '1' for read/rx channel. So I should be
setting this to 1 like this?
dmas = <&axi_dma_0 1>;
dma-names = "axi_dma_0";
But where does that field get used?