Re: [PATCH] ARM: dts: omap36xx: Remove turbo mode for 1GHz variants

From: H. Nikolaus Schaller
Date: Sat Jan 09 2021 - 12:00:45 EST


Hi Adam,

> Am 09.01.2021 um 17:39 schrieb Adam Ford <aford173@xxxxxxxxx>:
>
> Previously, the 1GHz variants were marked as a turbo,
> because that variant has reduced thermal operating range.
>
> Now that the thermal throttling is in place, it should be
> safe to remove the turbo-mode from the 1GHz variants, because
> the CPU will automatically slow if the thermal limit is reached.

Subject and description may be misunderstood in a way that 1GHz
is now disabled.

Rather the 1GHz OPP is now permanently enabled and does no longer
need to be manuall enabled through something like
/sys/devices/system/cpu/cpufreq/boost.

>
> Signed-off-by: Adam Ford <aford173@xxxxxxxxx>
>
> diff --git a/arch/arm/boot/dts/logicpd-torpedo-som.dtsi b/arch/arm/boot/dts/logicpd-torpedo-som.dtsi
> index 3a5228562b0d..3451f9be104e 100644
> --- a/arch/arm/boot/dts/logicpd-torpedo-som.dtsi
> +++ b/arch/arm/boot/dts/logicpd-torpedo-som.dtsi
> @@ -70,6 +70,7 @@ nand@0,0 {
> gpmc,device-width = <2>;
> #address-cells = <1>;
> #size-cells = <1>;
> + status = "disabled";

this does not seem to match the description?

> };
> };
>
> --
> 2.25.1
>

BR,
Nikolaus