RE: [PATCH v8 04/20] dlb: add device ioctl layer and first three ioctls

[Chen, Mike Ximing]

> -----Original Message-----
> From: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
> Sent: Thursday, January 7, 2021 2:42 PM
> To: Chen, Mike Ximing <mike.ximing.chen@xxxxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx; arnd@xxxxxxxx; Williams, Dan J
> <dan.j.williams@xxxxxxxxx>; pierre-louis.bossart@xxxxxxxxxxxxxxx; Gage Eads
> <gage.eads@xxxxxxxxx>
> Subject: Re: [PATCH v8 04/20] dlb: add device ioctl layer and first three ioctls
> 
> > +/* [7:0]: device revision, [15:8]: device version */
> > +#define DLB_SET_DEVICE_VERSION(ver, rev) (((ver) << 8) | (rev))
> > +
> > +static int
> > +dlb_ioctl_get_device_version(struct dlb *dlb __attribute__((unused)),
> 
> We don't use __attribute__((unused)) for function variables in Linux.
> Please remove and tell whatever operating system you ported this from to
> get with the times :)
> 
> thanks,
> 
> greg k-h

OK. Will remove __attribute__((unused)) in the patch set.

Thanks!

Mike