Re: [PATCH] mm,hwpoison: Fix printing of page flags

From: Anshuman Khandual
Date: Fri Jan 08 2021 - 04:29:46 EST




On 1/8/21 2:22 PM, Oscar Salvador wrote:
> Format %pG expects a lower case 'p' in order to print the flags.
> Fix it.
>
> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Signed-off-by: Oscar Salvador <osalvador@xxxxxxx>
> Fixes: 8295d535e2aa ("mm,hwpoison: refactor get_any_page")

Reviewed-by: Anshuman Khandual <anshuman.khandual@xxxxxxx>

> ---
> mm/memory-failure.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/memory-failure.c b/mm/memory-failure.c
> index 5a38e9eade94..04d9f154a130 100644
> --- a/mm/memory-failure.c
> +++ b/mm/memory-failure.c
> @@ -1940,7 +1940,7 @@ int soft_offline_page(unsigned long pfn, int flags)
> goto retry;
> }
> } else if (ret == -EIO) {
> - pr_info("%s: %#lx: unknown page type: %lx (%pGP)\n",
> + pr_info("%s: %#lx: unknown page type: %lx (%pGp)\n",
> __func__, pfn, page->flags, &page->flags);
> }
>
>