Re: [PATCH] octeontx2-af: fix memory leak of lmac and lmac->name

From: Jakub Kicinski
Date: Thu Jan 07 2021 - 21:43:22 EST


On Thu, 7 Jan 2021 22:31:30 +0530 Sunil Kovvuri wrote:
> On Thu, Jan 7, 2021 at 6:11 PM Colin King <colin.king@xxxxxxxxxxxxx> wrote:
> >
> > From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> >
> > Currently the error return paths don't kfree lmac and lmac->name
> > leading to some memory leaks. Fix this by adding two error return
> > paths that kfree these objects
> >
> > Addresses-Coverity: ("Resource leak")
> > Fixes: 1463f382f58d ("octeontx2-af: Add support for CGX link management")
> > Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Thanks for the fix, looks good to me.

Consider venturing an Acked-by tag in the future so it can be recorded
in git.

Applied, thanks!