Re: [PATCH] usb: dwc3: Replace of_reset_control_array_get()

From: Dmitry Osipenko
Date: Thu Jan 07 2021 - 14:34:01 EST


03.11.2020 12:25, Yejune Deng пишет:
> of_reset_control_array_get_optional_exclusive() looks more readable
>
> Signed-off-by: Yejune Deng <yejune.deng@xxxxxxxxx>
> ---
> drivers/usb/dwc3/dwc3-of-simple.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c
> index e62ecd2..e358ff0 100644
> --- a/drivers/usb/dwc3/dwc3-of-simple.c
> +++ b/drivers/usb/dwc3/dwc3-of-simple.c
> @@ -52,8 +52,7 @@ static int dwc3_of_simple_probe(struct platform_device *pdev)
> if (of_device_is_compatible(np, "rockchip,rk3399-dwc3"))
> simple->need_reset = true;
>
> - simple->resets = of_reset_control_array_get(np, false, true,
> - true);
> + simple->resets = of_reset_control_array_get_optional_exclusive(np);
> if (IS_ERR(simple->resets)) {
> ret = PTR_ERR(simple->resets);
> dev_err(dev, "failed to get device resets, err=%d\n", ret);
>

Reviewed-by: Dmitry Osipenko <digetx@xxxxxxxxx>