Re: [PATCH net-next] net: sysctl: cleanup net_sysctl_init()
From: Jakub Kicinski
Date: Wed Jan 06 2021 - 19:31:40 EST
On Wed, 06 Jan 2021 20:40:28 +0000 Alexander Lobakin wrote:
> 'net_header' is not used outside of this function, so can be moved
> from BSS onto the stack.
> Declarations of one-element arrays are discouraged, and there's no
> need to store 'empty' in BSS. Simply allocate it from heap at init.
Are you sure? It's passed as an argument to register_sysctl()
so it may well need to be valid for the lifetime of net_header.