Re: [PATCH -next] mtd: st_spi_fsm: use resource_size

From: Miquel Raynal
Date: Wed Jan 06 2021 - 09:52:19 EST


Hello,

Zheng Yongjun <zhengyongjun3@xxxxxxxxxx> wrote on Wed, 6 Jan 2021
21:18:47 +0800:

> Use resource_size rather than a verbose computation on
> the end and start fields.
>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@xxxxxxxxxx>
> ---
> drivers/mtd/devices/st_spi_fsm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/devices/st_spi_fsm.c b/drivers/mtd/devices/st_spi_fsm.c
> index 1888523d9745..983999c020d6 100644
> --- a/drivers/mtd/devices/st_spi_fsm.c
> +++ b/drivers/mtd/devices/st_spi_fsm.c
> @@ -924,7 +924,7 @@ static int stfsm_read_status(struct stfsm *fsm, uint8_t cmd,
> BUG_ON(bytes != 1 && bytes != 2);
>
> seq->seq_opc[0] = (SEQ_OPC_PADS_1 | SEQ_OPC_CYCLES(8) |
> - SEQ_OPC_OPCODE(cmd)),
> + SEQ_OPC_OPCODE(cmd));
>
> stfsm_load_seq(fsm, seq);
>

Same remark again, description and actual change do not match.

Thanks,
Miquèl