Re: [PATCH 3/6] block: don't allocate inline bvecs if this bioset needn't bvecs

From: Christoph Hellwig
Date: Mon Jan 04 2021 - 03:56:18 EST


On Wed, Dec 30, 2020 at 08:32:52AM +0800, Ming Lei wrote:
> The inline bvecs won't be used if user needn't bvecs by not passing
> BIOSET_NEED_BVECS, so don't allocate bvecs in this situation.

Looks sensible.

> - bs->bio_slab = bio_find_or_create_slab(front_pad + back_pad);
> + bs->bio_slab = bio_find_or_create_slab(bs->front_pad + bs->back_pad);

Passing the bioset to bio_find_or_create_slab and returning an errno
might be a nicer calling convention now.