Re: [PATCH] mmc: sdhci-msm: Fix possible NULL pointer exception

From: Veerabhadrarao Badiganti
Date: Thu Dec 31 2020 - 01:47:39 EST



On 12/22/2020 2:18 PM, Md Sadre Alam wrote:
of_device_get_match_data returns NULL when no match.
So add the NULL pointer check to avoid dereference.

Signed-off-by: Md Sadre Alam <mdalam@xxxxxxxxxxxxxx>
---

Reviewed-by: Veerabhadrarao Badiganti <vbadigan@xxxxxxxxxxxxxx>

drivers/mmc/host/sdhci-msm.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
index 9c7927b..f20e424 100644
--- a/drivers/mmc/host/sdhci-msm.c
+++ b/drivers/mmc/host/sdhci-msm.c
@@ -2235,6 +2235,8 @@ static int sdhci_msm_probe(struct platform_device *pdev)
* the data associated with the version info.
*/
var_info = of_device_get_match_data(&pdev->dev);
+ if (!var_info)
+ goto pltfm_free;
msm_host->mci_removed = var_info->mci_removed;
msm_host->restore_dll_config = var_info->restore_dll_config;