Re: [RFC: timer passthrough 0/9] Support timer passthrough for VM

From: Sean Christopherson
Date: Mon Dec 28 2020 - 18:29:21 EST


On Mon, Dec 28, 2020, Zhimin Feng wrote:
> The main motivation for this patch is to improve the performance of VM.

Do you have numbers that show when this improves performance, and by how much?

This adds hundreds of cycles of overhead (VMWRITEs, WRMSRs, RDMSRs, etc...) to
_every_ VM-Exit roundtrip, and the timer IRQ still incurs a VM-Exit. It's not
obvious that this is a net win, and it adds a fair amount of complexity and
subtlety, e.g. there are multiple corner cases this gets wrong. I suspect
you'll have a tough time getting this reviewed, let alone merged, without hard
numbers to justify the complexity and review effort.