RE: [PATCH V5 0/5] can: flexcan: add stop mode support for i.MX8QM

From: Joakim Zhang
Date: Tue Dec 22 2020 - 06:38:27 EST



> -----Original Message-----
> From: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
> Sent: 2020年11月6日 19:33
> To: Joakim Zhang <qiangqing.zhang@xxxxxxx>; robh+dt@xxxxxxxxxx;
> shawnguo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx
> Cc: kernel@xxxxxxxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx>;
> linux-can@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH V5 0/5] can: flexcan: add stop mode support for i.MX8QM
>
> On 11/6/20 11:56 AM, Joakim Zhang wrote:
> > Add stop mode support for i.MX8QM.
> >
> > ChangeLogs:
> > V4->V5:
> > * remove patch:firmware: imx: always export SCU symbols, since
> > it done by commit: 95de5094f5ac firmware: imx: add dummy functions
> > * rebase to fsl,flexcan.yaml
> >
> > V3->V4:
> > * can_idx->scu_idx.
> > * return imx_scu_get_handle(&priv->sc_ipc_handle);
> > * failed_canregister->failed_setup_stop_mode.
> >
> > V2->V3:
> > * define IMX_SC_R_CAN(x) in rsrc.h
> > * remove error message on -EPROBE_DEFER.
> > * split disable wakeup patch into separate one.
> >
> > V1->V2:
> > * split ECC fix patches into separate patches.
> > * free can dev if failed to setup stop mode.
> > * disable wakeup on flexcan_remove.
> > * add FLEXCAN_IMX_SC_R_CAN macro helper.
> > * fsl,can-index->fsl,scu-index.
> > * move fsl,scu-index and priv->can_idx into
> > * flexcan_setup_stop_mode_scfw()
> > * prove failed if failed to setup stop mode.
> >
> > Joakim Zhang (5):
> > dt-bindings: can: flexcan: fix fsl,clk-source property
>
> added to linux-can/testing
>
> > dt-bindings: can: flexcan: add fsl,scu-index property to indicate a
> > resource
> > can: flexcan: rename macro FLEXCAN_QUIRK_SETUP_STOP_MODE ->
> > FLEXCAN_QUIRK_SETUP_STOP_MODE_GPR
> > dt-bindings: firmware: add IMX_SC_R_CAN(x) macro for CAN
> > can: flexcan: add CAN wakeup function for i.MX8QM
>
> The others go via linux-can-next/testing, once net/master is merged back to
> net-next/master to have the yaml bindings.

Hi Marc,

How about below patches? I even can't see it in your linux-can-next/testing branch. Are these missed?
dt-bindings: can: flexcan: add fsl,scu-index property to indicate a resource
can: flexcan: add CAN wakeup function for i.MX8QM

Best Regards,
Joakim Zhang