Re: [PATCH v5 2/3] spi: Add SPI_NO_TX/RX support

From: Andy Shevchenko
Date: Mon Dec 21 2020 - 13:21:39 EST


On Mon, Dec 21, 2020 at 5:19 PM Ardelean, Alexandru
<alexandru.Ardelean@xxxxxxxxxx> wrote:
> > -----Original Message-----
> > From: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
> > Sent: Monday, December 21, 2020 4:37 PM
> > On Mon, Dec 21, 2020 at 4:34 PM Andy Shevchenko
> > <andy.shevchenko@xxxxxxxxx> wrote:

...

> > One nit, though...
> >
> > > > - "setup: can not select dual and quad at the same time\n");
> > > > + "setup: can not select any two of dual, quad and no-rx/tx "
> > > > + "at the same time\n");
> >
> > Can we avoid splitting string literals which are assumed to be on one line when
> > printed?
>
> It ends up at about 96 cols, but it's within limits.
> The patch may have been written before the new 100 col-width limit.

JFYI: string literals do not have limits (neither 80, nor 100).
It's a special category.

--
With Best Regards,
Andy Shevchenko