Re: [PATCH v4] iio: Handle enumerated properties with gaps

From: Andy Shevchenko
Date: Mon Dec 21 2020 - 13:01:18 EST


On Mon, Dec 21, 2020 at 5:11 PM Alexandru Ardelean
<alexandru.ardelean@xxxxxxxxxx> wrote:
>
> From: Lars-Peter Clausen <lars@xxxxxxxxxx>
>
> Some enums might have gaps or reserved values in the middle of their value
> range. E.g. consider a 2-bit enum where the values 0, 1 and 3 have a
> meaning, but 2 is a reserved value and can not be used.
>
> Add support for such enums to the IIO enum helper functions. A reserved
> values is marked by setting its entry in the items array to NULL rather
> than the normal descriptive string value.

...

> I tried a few shots at working with 'lib/string.c', and that went
> slow. The __sysfs_match_string_with_gaps() approach has stalled.
> https://lore.kernel.org/linux-iio/20190422140251.8960-1-alexandru.ardelean@xxxxxxxxxx/

Hmm... If you are not going to push that forward, perhaps better is to provide
iio_sysfs_match_string() and if we need it in the future for other
users, it would be easier to find and export. Also it will be a matter
of one line change in the caller.

--
With Best Regards,
Andy Shevchenko