RE: [PATCH] scsi: ufs: fix livelock of ufshcd_clear_ua_wluns

From: Avri Altman
Date: Mon Dec 21 2020 - 12:01:44 EST


> > > When gate_work/ungate_work gets an error during hibern8_enter or
> exit,
> > > ufshcd_err_handler()
> > > ufshcd_scsi_block_requests()
> > > ufshcd_reset_and_restore()
> > > ufshcd_clear_ua_wluns() -> stuck
> > > ufshcd_scsi_unblock_requests()
> > >
> > > In order to avoid it, ufshcd_clear_ua_wluns() can be called per recovery
> > > flows
> > > such as suspend/resume, link_recovery, and error_handler.
> > Not sure that suspend/resume are UAC events?
>
> Could you elaborate a bit? The goal is to clear UAC after UFS reset happens.
So why calling it on every suspend and resume?

>
> >
> > Also the 'fixes' tag is missing.
>
> Added. Thanks,
>
> >
> > Thanks,
> > Avri