Re: [PATCH v3 3/7] mfd: Add MFD driver for ATC260x PMICs

From: Linus Walleij
Date: Mon Dec 21 2020 - 07:19:27 EST


On Mon, Dec 21, 2020 at 12:59 PM Cristian Ciocaltea
<cristian.ciocaltea@xxxxxxxxx> wrote:

> enum atc260x_ver {
> ATC260X_A = 0,
> ATC260X_B,
> ATC260X_C,
> ATC260X_D,
> ATC260X_E,
> ATC260X_F,
> ATC260X_G,
> ATC260X_H,
> };

This makes it look like the driver is actually so generic that it makes space
for all revisions back to ATC2603A which is in the Ainol Hero 10 tablet.

This is nice because there are millions of these devices (especially in
China) that people want to get to run the latest Linux.

I even wonder how much different the ATM7029 is from S500, I suspect
not super much apart from the ARM cores.

Good work overall! I'll be happy to deal with the GPIO
driver when you get there.

Yours,
Linus Walleij