RE: [PATCH v8 4/4] soc: imx8m: change to use platform driver

[Alice Guo (OSS)]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Sent: 2020年12月19日 20:18
> To: Alice Guo (OSS) <alice.guo@xxxxxxxxxxx>
> Cc: robh+dt@xxxxxxxxxx; shawnguo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx;
> kernel@xxxxxxxxxxxxxx; festevam@xxxxxxxxx; devicetree@xxxxxxxxxxxxxxx;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; dl-linux-imx
> <linux-imx@xxxxxxx>
> Subject: Re: [PATCH v8 4/4] soc: imx8m: change to use platform driver
> 
> On Fri, Dec 18, 2020 at 04:37:26PM +0800, Alice Guo (OSS) wrote:
> > From: Alice Guo <alice.guo@xxxxxxx>
> >
> > Directly reading ocotp register depends on that bootloader enables
> > ocotp clk, which is not always effective, so change to use nvmem API.
> > Using nvmem API requires to support driver defer probe and thus change
> > soc-imx8m.c to use platform driver.
> >
> > The other reason is that directly reading ocotp register causes kexec
> > kernel hang because the 1st kernel running will disable unused clks
> > after kernel boots up, and then ocotp clk will be disabled even if
> > bootloader enables it. When kexec kernel, ocotp clk needs to be
> > enabled before reading ocotp registers, and nvmem API with platform
> > driver supported can accomplish this.
> >
> > Signed-off-by: Alice Guo <alice.guo@xxxxxxx>
> > ---
> > Changes for v8:
> >  - none
> > Changes for v7:
> >  - solve the problem "drivers/soc/imx/soc-imx8m.c:174:34: warning:
> >    unused variable"
> 
> There was a reviewed-by part of changelog. The tag was in your commit.
> I am now confused, as changes for v8 say "none"... but shall I trust it?
> 
> Best regards,
> Krzysztof

Hi,
I forgot to add reviewed-by.

Best regards,
Alice