RE: [PATCH] block: aoe: replace use of __constant_htons to htons

From: David Laight
Date: Sun Dec 20 2020 - 14:44:21 EST


From: Amey Narkhede
> Sent: 20 December 2020 16:46
>
> The macro htons expands to __swab16 which has special
> case for constants in little endian case. In big
> endian case both __constant_htons and htons macros
> expand to the same code. So, replace __constant_htons
> with htons to get rid of the definition of __constant_htons
> completely.
>
...
> static struct packet_type aoe_pt __read_mostly = {
> - .type = __constant_htons(ETH_P_AOE),
> + .type = htons(ETH_P_AOE),
> .func = aoenet_rcv,

Does this cause grief if someone is doing a COMPILE_TEST on LE?

David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)