Re: [PATCH v2] inotify, memcg: account inotify instances to kmemcg

[Shakeel Butt]

On Sun, Dec 20, 2020 at 3:32 AM Amir Goldstein <amir73il@xxxxxxxxx> wrote:
>
> On Sun, Dec 20, 2020 at 6:46 AM Shakeel Butt <shakeelb@xxxxxxxxxx> wrote:
> >
> > Currently the fs sysctl inotify/max_user_instances is used to limit the
> > number of inotify instances on the system. For systems running multiple
> > workloads, the per-user namespace sysctl max_inotify_instances can be
> > used to further partition inotify instances. However there is no easy
> > way to set a sensible system level max limit on inotify instances and
> > further partition it between the workloads. It is much easier to charge
> > the underlying resource (i.e. memory) behind the inotify instances to
> > the memcg of the workload and let their memory limits limit the number
> > of inotify instances they can create.
> >
> > With inotify instances charged to memcg, the admin can simply set
> > max_user_instances to INT_MAX and let the memcg limits of the jobs limit
> > their inotify instances.
> >
> > Signed-off-by: Shakeel Butt <shakeelb@xxxxxxxxxx>
> Reviewed-by: Amir Goldstein <amir73il@xxxxxxxxx>

Thanks a lot.