Re: [EXT] Re: [PATCH 1/2] mmc: Support kmsg dumper based on pstore/blk

From: Kees Cook
Date: Fri Dec 18 2020 - 13:51:26 EST


On Wed, Dec 16, 2020 at 11:44:26AM +0100, Ulf Hansson wrote:
> In any case, I didn't catch *why* pstore needs to force block device
> drivers to implement specific pstore hooks to support the pstore file
> system. I don't think this is the way it should work, for many

For panic, pstore must avoid any path that might sleep. In a perfect
world, it should also use as little code as possible, to avoid
potentially tripping over areas of the kernel that might be broken.

--
Kees Cook