Re: [PATCH] ASoC: wm8962: Add optional mclk device tree binding

From: Geert Uytterhoeven
Date: Fri Dec 18 2020 - 07:59:47 EST


On Thu, Dec 17, 2020 at 5:27 PM Adam Ford <aford173@xxxxxxxxx> wrote:
> The driver can request an optional clock for mclk.
> Update the txt file to reflect this.
>
> Suggested-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Signed-off-by: Adam Ford <aford173@xxxxxxxxx>

Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

> --- a/Documentation/devicetree/bindings/sound/wm8962.txt
> +++ b/Documentation/devicetree/bindings/sound/wm8962.txt
> @@ -9,6 +9,9 @@ Required properties:
> - reg : the I2C address of the device.
>
> Optional properties:
> +

This blank line is not needed (but it will probably be removed during a
future txt-to-yaml conversion ;-)

> + - clocks : The clock source of the mclk
> +
> - spk-mono: This is a boolean property. If present, the SPK_MONO bit
> of R51 (Class D Control 2) gets set, indicating that the speaker is
> in mono mode.
> @@ -27,6 +30,7 @@ Example:
> wm8962: codec@1a {
> compatible = "wlf,wm8962";
> reg = <0x1a>;
> + clocks = <&clks IMX6QDL_CLK_CKO>;
>
> gpio-cfg = <
> 0x0000 /* 0:Default */

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds