Re: [PATCH v3 6/6] ARM: dts: Add dts for RPi4b + Cirrus Logic Lochnagar2 + CS47L15
From: Florian Fainelli
Date: Thu Dec 17 2020 - 12:12:36 EST
On 12/17/20 7:41 AM, 'Richard Fitzgerald' via
BCM-KERNEL-FEEDBACK-LIST,PDL wrote:
> This adds a devicetree configuration for Raspberry Pi 4b connected to
> Cirrus Logic Lochnagar 2 audio development board and CS47L15 codec.
>
> The common (codec-independent) Lochnagar 2 configuration is separated
> into a dtsi to simplify re-using it for other codecs.
>
> Signed-off-by: Richard Fitzgerald <rf@xxxxxxxxxxxxxxxxxxxxx>
> ---
> MAINTAINERS | 1 +
> arch/arm/boot/dts/Makefile | 1 +
> ...bcm2711-rpi4b-cirrus-lochnagar-cs47l15.dts | 186 ++++++++++++++++
> .../dts/bcm2711-rpi4b-cirrus-lochnagar.dtsi | 201 ++++++++++++++++++
> 4 files changed, 389 insertions(+)
> create mode 100644 arch/arm/boot/dts/bcm2711-rpi4b-cirrus-lochnagar-cs47l15.dts
> create mode 100644 arch/arm/boot/dts/bcm2711-rpi4b-cirrus-lochnagar.dtsi
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 5cc595ac7b28..7dca1db52144 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -4193,6 +4193,7 @@ M: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx>
> M: Richard Fitzgerald <rf@xxxxxxxxxxxxxxxxxxxxx>
> L: patches@xxxxxxxxxxxxxxxxxxxxx
> S: Supported
> +F: arch/arm/boot/dts/bcm2711-rpi4b-cirrus-lochnagar*
> F: Documentation/devicetree/bindings/clock/cirrus,lochnagar.yaml
> F: Documentation/devicetree/bindings/hwmon/cirrus,lochnagar.yaml
> F: Documentation/devicetree/bindings/mfd/cirrus,lochnagar.yaml
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index ce66ffd5a1bb..240cc58fd954 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -93,6 +93,7 @@ dtb-$(CONFIG_ARCH_BCM2835) += \
> bcm2837-rpi-3-b-plus.dtb \
> bcm2837-rpi-cm3-io3.dtb \
> bcm2711-rpi-4-b.dtb \
> + bcm2711-rpi4b-cirrus-lochnagar-cs47l15.dtb \
Is there a reason you are not following the convention established above
and have this file be named: bcm2711-rpi-4-b-cirrus-lochnagar-cs47l15.dtb?
--
Florian