Re: [PATCH v5 1/7] pwm: pca9685: Switch to atomic API

From: Sven Van Asbroeck
Date: Thu Dec 17 2020 - 12:11:22 EST


On Thu, Dec 17, 2020 at 11:48 AM Clemens Gruber
<clemens.gruber@xxxxxxxxxxxx> wrote:
>
> I can initialize the values to 0 of course and check the file for other
> places with missing initializations.
>
> Or would it be better to check the return codes of regmap_read/write in
> such cases? I'm not sure.

I think that checking the regmap_read/write return values is overkill
in this driver. These functions can't realistically fail, except if the i2c
bus is bad, i.e. h/w failure or intermittency. And that's an externality
which I believe we can ignore.

Maybe Thierry or Uwe have further insights here.