[PATCH v4 net-next 1/2] net: phy: mchp: Add interrupt support for Link up and Link down to LAN8814 phy

From: Divya Koppera
Date: Thu Dec 17 2020 - 07:42:49 EST


This patch add supports for Link up and Link down interrupts
to LAN8814 phy.

Signed-off-by: Divya Koppera<divya.koppera@xxxxxxxxxxxxx>
---
v1 -> v2
* Fixed warnings
Reported-by: kernel test robot <lkp@xxxxxxxxx>

v2 -> v3
* Splitting 1588 support patch to Link up/down patch
and 1588 support patch.

v3 -> v4
* Changed MAC API call to phy_trigger_machine.
---
drivers/net/phy/micrel.c | 65 ++++++++++++++++++++++++++++++++++++++++
1 file changed, 65 insertions(+)

diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
index 54e0d75203da..3a9d87f5d7c5 100644
--- a/drivers/net/phy/micrel.c
+++ b/drivers/net/phy/micrel.c
@@ -27,6 +27,14 @@
#include <linux/of.h>
#include <linux/clk.h>
#include <linux/delay.h>
+#include <linux/ptp_clock_kernel.h>
+#include <linux/ptp_clock.h>
+#include <linux/ptp_classify.h>
+#include <linux/net_tstamp.h>
+#include <linux/netdevice.h>
+#include <linux/if_vlan.h>
+#include <linux/ip.h>
+#include <linux/ipv6.h>

/* Operation Mode Strap Override */
#define MII_KSZPHY_OMSO 0x16
@@ -53,6 +61,31 @@
#define KSZPHY_INTCS_STATUS (KSZPHY_INTCS_LINK_DOWN_STATUS |\
KSZPHY_INTCS_LINK_UP_STATUS)

+/* Lan8814 general Interrupt control/status reg in GPHY specific block. */
+#define LAN8814_INTC 0x18
+#define LAN8814_INTC_JABBER BIT(7)
+#define LAN8814_INTC_RECEIVE_ERR BIT(6)
+#define LAN8814_INTC_PAGE_RECEIVE BIT(5)
+#define LAN8814_INTC_PARELLEL BIT(4)
+#define LAN8814_INTC_LINK_PARTNER_ACK BIT(3)
+#define LAN8814_INTC_LINK_DOWN BIT(2)
+#define LAN8814_INTC_REMOTE_FAULT BIT(1)
+#define LAN8814_INTC_LINK_UP BIT(0)
+#define LAN8814_INTC_ALL (LAN8814_INTC_LINK_UP |\
+ LAN8814_INTC_LINK_DOWN)
+
+#define LAN8814_INTS 0x1B
+#define LAN8814_INTS_JABBER BIT(7)
+#define LAN8814_INTS_RECEIVE_ERR BIT(6)
+#define LAN8814_INTS_PAGE_RECEIVE BIT(5)
+#define LAN8814_INTS_PARELLEL BIT(4)
+#define LAN8814_INTS_LINK_PARTNER_ACK BIT(3)
+#define LAN8814_INTS_LINK_DOWN BIT(2)
+#define LAN8814_INTS_REMOTE_FAULT BIT(1)
+#define LAN8814_INTS_LINK_UP BIT(0)
+#define LAN8814_INTS_ALL (LAN8814_INTS_LINK_UP |\
+ LAN8814_INTS_LINK_DOWN)
+
/* PHY Control 1 */
#define MII_KSZPHY_CTRL_1 0x1e

@@ -76,6 +109,9 @@
#define MII_KSZPHY_TX_DATA_PAD_SKEW 0x106

#define PS_TO_REG 200
+#define KSZ_EXT_PAGE_ACCESS_CONTROL 0x16
+#define KSZ_EXT_PAGE_ACCESS_ADDRESS_DATA 0x17
+#define OFF_PTP_CONTROL 32 /* PTPv1 only */

struct kszphy_hw_stat {
const char *string;
@@ -149,6 +185,33 @@ static int kszphy_extended_read(struct phy_device *phydev,
return phy_read(phydev, MII_KSZPHY_EXTREG_READ);
}

+static irqreturn_t lan8814_handle_interrupt(struct phy_device *phydev)
+{
+ int irq_status;
+
+ irq_status = phy_read(phydev, LAN8814_INTS);
+ if (irq_status < 0)
+ return IRQ_NONE;
+
+ if (irq_status & LAN8814_INTS_ALL)
+ phy_trigger_machine(phydev);
+
+ return IRQ_HANDLED;
+}
+
+static int lan8814_config_intr(struct phy_device *phydev)
+{
+ int temp;
+
+ /* enable / disable interrupts */
+ if (phydev->interrupts == PHY_INTERRUPT_ENABLED)
+ temp = LAN8814_INTC_ALL;
+ else
+ temp = 0;
+
+ return phy_write(phydev, LAN8814_INTC, temp);
+}
+
static int kszphy_ack_interrupt(struct phy_device *phydev)
{
/* bit[7..0] int status, which is a read and clear register. */
@@ -1360,6 +1423,8 @@ static struct phy_driver ksphy_driver[] = {
.get_stats = kszphy_get_stats,
.suspend = genphy_suspend,
.resume = kszphy_resume,
+ .config_intr = lan8814_config_intr,
+ .handle_interrupt = lan8814_handle_interrupt,
}, {
.phy_id = PHY_ID_KSZ9131,
.phy_id_mask = MICREL_PHY_ID_MASK,
--
2.17.1