Re: [PATCH v2 3/8] dt-bindings: regulator: Add document for MT6359 regulator

From: Mark Brown
Date: Wed Dec 16 2020 - 08:06:48 EST


On Wed, Dec 16, 2020 at 12:34:19PM +0800, Hsin-hsiung Wang wrote:
> On Wed, 2020-09-23 at 17:24 +0100, Mark Brown wrote:
> > On Mon, Sep 21, 2020 at 07:48:10PM +0800, Hsin-Hsiung Wang wrote:

> > > +Required properties:
> > > +- compatible: "mediatek,mt6359-regulator"

> > The compatible isn't used by the driver (which is good!) so should be
> > dropped from the binding document.

> Thanks for your comments, but I have a question about it.
> When I remove the compatible name in the dts, there will be some error
> message:
> [ 0.437562] mt6359-regulator: Failed to locate of_node [id: -1]
> [ 0.440612] mt6359-sound: Failed to locate of_node [id: -1]

> Do you mean that we don't need any compatible name in dts, mfd and
> regulator driver?

The MFD driver and DT node for the MFD will need a compatible. The
regulator function doesn't, it can just look things up based on the
parent.

Attachment: signature.asc
Description: PGP signature