Re: [PATCH] ASoC: imx-hdmi: Fix warning of the uninitialized variable ret

From: Fabio Estevam
Date: Wed Dec 16 2020 - 06:27:25 EST


Hi Shengjiu,

On Wed, Dec 16, 2020 at 7:52 AM Shengjiu Wang <shengjiu.wang@xxxxxxx> wrote:
>
> From: shengjiu wang <shengjiu.wang@xxxxxxx>
>
> When condition ((hdmi_out && hdmi_in) || (!hdmi_out && !hdmi_in))
> is true, then goto fail, the uninitialized variable ret will be
> returned.
>
> Signed-off-by: shengjiu wang <shengjiu.wang@xxxxxxx>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>

Thanks for the fix.

This should have:

Fixes: 6a5f850aa83a ("ASoC: fsl: Add imx-hdmi machine driver")

Reviewed-by: Fabio Estevam <festevam@xxxxxxxxx>