Re: [PATCH v3 12/12] mfd: bd9571mwv: Add support for BD9574MWF

From: Lee Jones
Date: Wed Dec 16 2020 - 04:03:03 EST


On Wed, 16 Dec 2020, Vaittinen, Matti wrote:

>
> On Wed, 2020-12-16 at 16:37 +0900, Yoshihiro Shimoda wrote:
> > From: Khiem Nguyen <khiem.nguyen.xt@xxxxxxxxxxx>
> >
> > The new PMIC BD9574MWF inherits features from BD9571MWV.
> > Add the support of new PMIC to existing bd9571mwv driver.
> >
> > Signed-off-by: Khiem Nguyen <khiem.nguyen.xt@xxxxxxxxxxx>
> > [shimoda: rebase and refactor]
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
>
> Reviewed-by: Matti Vaittinen <matti.vaittinen@xxxxxxxxxxxxxxxxx>
>
> > ---
> > drivers/mfd/bd9571mwv.c | 86
> > ++++++++++++++++++++++++++++++++++++++++++-
> > include/linux/mfd/bd9571mwv.h | 18 +++++++--
> > 2 files changed, 99 insertions(+), 5 deletions(-)

... and please snip long replies.

Scrolling down past lots of un-reviewed code and/or past the end of
the last review comment is a waste of people's time. Thanks.

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog