Re: [PATCH net-next] seg6: fix the max number of supported SRv6 behavior attributes

From: Jakub Kicinski
Date: Tue Dec 15 2020 - 20:48:14 EST


On Wed, 16 Dec 2020 02:08:34 +0100 Andrea Mayer wrote:
> I agree with this approach. Only for the sake of clarity I would prefer to
> define the macro SEG6_LOCAL_MAX_SUPP as follows:
>
> in seg6_local.c:
> [...]
>
> /* max total number of supported SRv6 behavior attributes */
> #define SEG6_LOCAL_MAX_SUPP 32
>
> int __init seg6_local_init(void)
> {
> BUILD_BUG_ON(SEG6_LOCAL_MAX + 1 > SEG6_LOCAL_MAX_SUPP);
> [...]
> }
>
>
> Due to the changes, I will submit a new patch (v1) with a more appropriate
> subject. The title of the new patch will most likely be:
>
> seg6: fool-proof the processing of SRv6 behavior attributes

SGTM, thanks!