Re: [PATCH net v3] lan743x: fix rx_napi_poll/interrupt ping-pong

From: Sven Van Asbroeck
Date: Tue Dec 15 2020 - 10:35:36 EST


Hi Jakub,

On Fri, Dec 11, 2020 at 9:38 AM Sven Van Asbroeck <thesven73@xxxxxxxxx> wrote:
>
> From: Sven Van Asbroeck <thesven73@xxxxxxxxx>
>
> Even if there is more rx data waiting on the chip, the rx napi poll fn
> will never run more than once - it will always read a few buffers, then
> bail out and re-arm interrupts. Which results in ping-pong between napi
> and interrupt.
>
> This defeats the purpose of napi, and is bad for performance.
>
> Fix by making the rx napi poll behave identically to other ethernet
> drivers:

I was wondering if maybe you had any lingering doubts about this patch?
Is there anything I can do to address these?