Re: Fw: [External] Re: [PATCH v4 0/4] Improve s0ix flows for systems i219LM

[Neftin, Sasha]

On 12/14/2020 20:40, Mark Pearson wrote:
> Thanks Hans
>
> On 14/12/2020 13:31, Mark Pearson wrote:
> > ------------------------------------------------------------------------
> > *From:* Hans de Goede <hdegoede@xxxxxxxxxx>
> > *Sent:* December 14, 2020 13:24
> > *To:* Mario Limonciello <mario.limonciello@xxxxxxxx>; Jeff Kirsher
> > <jeffrey.t.kirsher@xxxxxxxxx>; Tony Nguyen <anthony.l.nguyen@xxxxxxxxx>;
> > intel-wired-lan@xxxxxxxxxxxxxxxx <intel-wired-lan@xxxxxxxxxxxxxxxx>;
> > David Miller <davem@xxxxxxxxxxxxx>; Aaron Ma <aaron.ma@xxxxxxxxxxxxx>;
> > Mark Pearson <mpearson@xxxxxxxxxx>
> > *Cc:* linux-kernel@xxxxxxxxxxxxxxx <linux-kernel@xxxxxxxxxxxxxxx>;
> > Netdev <netdev@xxxxxxxxxxxxxxx>; Alexander Duyck
> > <alexander.duyck@xxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Sasha
> > Netfin <sasha.neftin@xxxxxxxxx>; Aaron Brown <aaron.f.brown@xxxxxxxxx>;
> > Stefan Assmann <sassmann@xxxxxxxxxx>; darcari@xxxxxxxxxx
> > <darcari@xxxxxxxxxx>; Yijun.Shen@xxxxxxxx <Yijun.Shen@xxxxxxxx>;
> > Perry.Yuan@xxxxxxxx <Perry.Yuan@xxxxxxxx>; anthony.wong@xxxxxxxxxxxxx
> > <anthony.wong@xxxxxxxxxxxxx>
> > *Subject:* [External] Re: [PATCH v4 0/4] Improve s0ix flows for systems
> > i219LM
> >   
> > Hi All,
> <snip>
> > ###
> >
> > I've added Mark Pearson from Lenovo to the Cc so that Lenovo
> > can investigate this issue further.
> >
> > Mark, this thread is about an issue with enabling S0ix support for
> > e1000e (i219lm) controllers. This was enabled in the kernel a
> > while ago, but then got disabled again on vPro / AMT enabled
> > systems because on some systems (Lenovo X1C7 and now also X1C8)
> > this lead to suspend/resume issues.
> >
> > When AMT is active then there is a handover handshake for the
> > OS to get access to the ethernet controller from the ME. The
> > Intel folks have checked and the Windows driver is using a timeout
> > of 1 second for this handshake, yet on Lenovo systems this is
> > taking 2 seconds. This likely has something to do with the
> > ME firmware on these Lenovo models, can you get the firmware
> > team at Lenovo to investigate this further ?
> Absolutely - I'll ask them to look into this again.
we need to explain why on Windows systems required 1s and on Linux 
systems up to 2.5s - otherwise it is not reliable approach - you will 
encounter others buggy system.
(ME not POR on the Linux systems - is only one possible answer)
> We did try to make progress with this previously - but it got a bit
> stuck and hence the need for these patches....but I believe things may
> have changed a bit so it's worth trying again
>
> Mark
Sasha