Re: [PATCH] proc: Escape more characters in /proc/mounts output

From: Al Viro
Date: Tue Dec 15 2020 - 01:11:25 EST


On Tue, Dec 15, 2020 at 09:54:54AM +0530, Siddhesh Poyarekar wrote:

> + get_user(byte, (const char __user *)data);
> +
> + return byte ? strndup_user(data, PATH_MAX) : NULL;
> }

No. Not to mention anything else, you
* fetch the same data twice
* fail to check the get_user() results