Re: [PATCH v3 1/3] UBI: Do not zero out EC and VID on ECC-ed NOR flashes

From: Richard Weinberger
Date: Sun Dec 13 2020 - 18:27:21 EST


On Tue, Dec 8, 2020 at 7:17 PM Pratyush Yadav <p.yadav@xxxxxx> wrote:
>
> Richard,
>
> On 01/12/20 03:57PM, Pratyush Yadav wrote:
> > For NOR flashes EC and VID are zeroed out before an erase is issued to
> > make sure UBI does not mistakenly treat the PEB as used and associate it
> > with an LEB.
> >
> > But on some flashes, like the Cypress Semper S28 SPI NOR flash family,
> > multi-pass page programming is not allowed on the default ECC scheme.
> > This means zeroing out these magic numbers will result in the flash
> > throwing a page programming error.
> >
> > Do not zero out EC and VID for such flashes. A writesize > 1 is an
> > indication of an ECC-ed flash.
>
> Patches 2/3 and 3/3 have been picked up in the spi-nor tree. Can you
> please pick this patch up?

Yep, patch is in my next tree.

--
Thanks,
//richard