Re: [PATCH] char: xillybus: Add driver for XillyUSB (Xillybus variant for USB)

From: Randy Dunlap
Date: Sun Dec 13 2020 - 12:24:04 EST


On 12/13/20 9:05 AM, eli.billauer@xxxxxxxxx wrote:
> diff --git a/drivers/char/xillybus/Kconfig b/drivers/char/xillybus/Kconfig
> index 130dbdce858f..18fa99ec1029 100644
> --- a/drivers/char/xillybus/Kconfig
> +++ b/drivers/char/xillybus/Kconfig
> @@ -32,3 +32,14 @@ config XILLYBUS_OF
> system, say M.
>
> endif # if XILLYBUS
> +

Hi Eli,

You don't want this new part inside the "if XILLYBUS" block above?
IOW, XILLYUSB does not need XILLYBUS?

> +config XILLYUSB
> + tristate "XillyUSB: Xillybus generic FPGA interface for USB"
> + depends on USB
> + select CRC32
> + help
> + XillyUSB is the Xillybus variant which uses USB for communicating
> + with the FPGA.
> +
> + Set to M if you want Xillybus to use USB for communicating with
> + the FPGA.

thanks.
--
~Randy