Re: [PATCH] mm/memory_hotplug: quieting offline operation

From: Souptick Joarder
Date: Sat Dec 12 2020 - 10:09:25 EST


On Fri, Dec 11, 2020 at 8:32 PM Laurent Dufour <ldufour@xxxxxxxxxxxxx> wrote:
>
> On PowerPC, when dymically removing memory from a system we can see in the console a
> lot of messages like this:
> [ 186.575389] Offlined Pages 4096

Is it specific to PowerPC ?

>
> This message is displayed on each LMB (256MB) removed, which means that we
> removing 1TB of memory, this message is displayed 4096 times.
>
> Moving it to DEBUG to not flood the console.
>
> Signed-off-by: Laurent Dufour <ldufour@xxxxxxxxxxxxx>
> ---
> mm/memory_hotplug.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index b44d4c7ba73b..c47a53a16782 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -1587,7 +1587,7 @@ int __ref offline_pages(unsigned long start_pfn, unsigned long nr_pages)
>
> /* Mark all sections offline and remove free pages from the buddy. */
> __offline_isolated_pages(start_pfn, end_pfn);
> - pr_info("Offlined Pages %ld\n", nr_pages);
> + pr_debug("Offlined Pages %ld\n", nr_pages);
>
> /*
> * The memory sections are marked offline, and the pageblock flags
> --
> 2.29.2
>
>