Re: [PATCH v2 1/3] dt-bindings: rtc: add reset-source property

[Uwe Kleine-König]

On Fri, Dec 11, 2020 at 10:56:09PM +0100, Rasmus Villemoes wrote:
> Some RTCs, e.g. the pcf2127, can be used as a hardware watchdog. But
> if the reset pin is not actually wired up, the driver exposes a
> watchdog device that doesn't actually work.
> 
> Provide a standard binding that can be used to indicate that a given
> RTC can perform a reset of the machine, similar to wakeup-source.
> 
> Suggested-by: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>
> Signed-off-by: Rasmus Villemoes <rasmus.villemoes@xxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/rtc/rtc.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/rtc/rtc.yaml b/Documentation/devicetree/bindings/rtc/rtc.yaml
> index ee237b2ed66a..b5e24dc24b0b 100644
> --- a/Documentation/devicetree/bindings/rtc/rtc.yaml
> +++ b/Documentation/devicetree/bindings/rtc/rtc.yaml
> @@ -47,4 +47,9 @@ properties:
>      description:
>        Enables wake up of host system on alarm.
>  
> +  reset-source:
> +    $ref: /schemas/types.yaml#/definitions/flag
> +    description:
> +      The RTC is able to reset the machine.

Thanks for picking that up.

Acked-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>

Note that the patch "rtc: pcf2127: move watchdog initialisation to a
separate function" is already in next.

Best regards
Uwe


-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Attachment: signature.asc
Description: PGP signature