Re: [PATCH v17 3/3] bus: mhi: Add userspace client interface driver

From: Jakub Kicinski
Date: Fri Dec 11 2020 - 23:09:45 EST


On Fri, 11 Dec 2020 11:37:34 -0600 Dan Williams wrote:
> Just to re-iterate: QMI ~= AT commands ~= MBIM (not quite, but same
> level)
>
> We already do QMI-over-USB, or AT-over-CDC-ACM. This is QMI-over-MHI.

Why do we need a different QMI-over-X for every X? If you say there
are already chardev interfaces to configure WWAN why not provide one
of those?

> It's not networking data plane. It's WWAN device configuration.

Ack. Not that network config doesn't fall under networking, but eh.
I wonder - did DaveM ever ack this, or was it just out of his sight
enough, behind the cdev, to never trigger a nack?

> There are no current kernel APIs for this, and I really don't think we
> want there to be. The API surface is *huge* and we definitely don't
> want that in-kernel.

It is what it is today for WWAN. I don't think anyone in the
development community or among users is particularly happy about
the situation. Which makes it rather self evident why there is
so much apprehension about this patch set. It's going to be
a user space channel for everything Qualcomm - AI accelerator etc.
Widening the WWAN status quo to more device types.