Re: [RFC 18/18] power: supply: max17040: Do not enforce (incorrect) interrupt trigger type

From: Krzysztof Kozlowski
Date: Fri Dec 11 2020 - 02:54:20 EST


On Thu, Dec 10, 2020 at 11:16:00PM +0100, Sebastian Reichel wrote:
> (I shortened the Cc)
>
> Hi,
>
> On Thu, Dec 10, 2020 at 10:25:34PM +0100, Krzysztof Kozlowski wrote:
> > [...]
> > index d956c67d5155..f737de0470de 100644
> > --- a/drivers/power/supply/max17040_battery.c
> > +++ b/drivers/power/supply/max17040_battery.c
> > @@ -367,7 +367,7 @@ static int max17040_enable_alert_irq(struct max17040_chip *chip)
> >
> > flags = IRQF_TRIGGER_FALLING | IRQF_ONESHOT;
> > ret = devm_request_threaded_irq(&client->dev, client->irq, NULL,
> > - max17040_thread_handler, flags,
> > + max17040_thread_handler, IRQF_ONESHOT,
> > chip->battery->desc->name, chip);
> >
> > return ret;
>
> 'flags' is unused after this change.

Indeed, thanks. Kbuild also complained now on my github branch. I'll fix
it in v2.