Re: [PATCH] riscv: Fixed kernel test robot warning

From: Palmer Dabbelt
Date: Thu Dec 10 2020 - 20:49:32 EST


On Tue, 08 Dec 2020 12:22:46 PST (-0800), schwab@xxxxxxxxxxxxxx wrote:
On Dez 09 2020, Souptick Joarder wrote:

On Wed, Dec 9, 2020 at 1:21 AM Andreas Schwab <schwab@xxxxxxxxxxxxxx> wrote:

On Dez 09 2020, Souptick Joarder wrote:

> Kernel test robot throws below warning -
>
> arch/riscv/kernel/asm-offsets.c:14:6: warning: no previous prototype
> for 'asm_offsets' [-Wmissing-prototypes]
> 14 | void asm_offsets(void)
> | ^~~~~~~~~~~
>
> This patch should fixed it.

Or rename it to main, like most other asm-offsets files.

Few asm-offsets files named it as foo(). Does a rename to main() will
work straight forward ?

Calling it main will suppress the warning, but other than that it is
completely irrelevant how you call it.

Ya, I think it doesn't really matter so I'm just going to take this as is.
It's on for-next (being a bit paranoid, as we're so late in the cycle).