Re: [PATCH v2 3/9] dt-bindings: pwm: Update DT binding docs to support SiFive FU740 SoC

From: Rob Herring
Date: Wed Dec 09 2020 - 22:57:59 EST


On Tue, Dec 08, 2020 at 10:25:35AM +0530, Yash Shah wrote:
> Add new compatible strings to the DT binding documents to support SiFive
> FU740-C000.
>
> Signed-off-by: Yash Shah <yash.shah@xxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/pwm/pwm-sifive.yaml | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pwm/pwm-sifive.yaml b/Documentation/devicetree/bindings/pwm/pwm-sifive.yaml
> index 5ac2527..84e6691 100644
> --- a/Documentation/devicetree/bindings/pwm/pwm-sifive.yaml
> +++ b/Documentation/devicetree/bindings/pwm/pwm-sifive.yaml
> @@ -25,12 +25,15 @@ description:
> properties:
> compatible:
> items:
> - - const: sifive,fu540-c000-pwm
> + - enum:
> + - sifive,fu540-c000-pwm
> + - sifive,fu740-c000-pwm
> - const: sifive,pwm0
> description:
> Should be "sifive,<chip>-pwm" and "sifive,pwm<version>". Supported
> - compatible strings are "sifive,fu540-c000-pwm" for the SiFive PWM v0
> - as integrated onto the SiFive FU540 chip, and "sifive,pwm0" for the
> + compatible strings are "sifive,fu540-c000-pwm" and
> + "sifive,fu740-c000-pwm" for the SiFive PWM v0 as integrated onto the
> + SiFive FU540 and FU740 chip respectively, and "sifive,pwm0" for the

Better if you reword this so we don't have to update it for every new
compatible.

> SiFive PWM v0 IP block with no chip integration tweaks.
> Please refer to sifive-blocks-ip-versioning.txt for details.
>
> --
> 2.7.4
>