Re: Revert "dm raid: remove unnecessary discard limits for raid10"

From: Song Liu
Date: Wed Dec 09 2020 - 18:15:16 EST




> On Dec 9, 2020, at 2:36 PM, Mike Snitzer <snitzer@xxxxxxxxxx> wrote:
>
> On Wed, Dec 09 2020 at 4:58pm -0500,
> Song Liu <songliubraving@xxxxxx> wrote:
>
>> This reverts commit f0e90b6c663a7e3b4736cb318c6c7c589f152c28.
>>
>> Matthew Ruffell reported data corruption in raid10 due to the changes
>> in discard handling [1]. Revert these changes before we find a proper fix.
>>
>> [1] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1907262/
>> Cc: Matthew Ruffell <matthew.ruffell@xxxxxxxxxxxxx>
>> Cc: Xiao Ni <xni@xxxxxxxxxx>
>> Cc: Mike Snitzer <snitzer@xxxxxxxxxx>
>> Signed-off-by: Song Liu <songliubraving@xxxxxx>
>
> If you're reverting all the MD code that enabled this DM change, then
> obviously the DM change must be reverted too. But please do _not_
> separate the DM revert from the MD reverts.

Good point! I should have thought about it through.

Thanks,
Song

[...]