Re: [PATCH 2/3] dt-bindings: pinctrl: Added binding for ZynqMP pinctrl driver

From: Rob Herring
Date: Wed Dec 09 2020 - 11:43:25 EST


On Wed, 09 Dec 2020 14:14:13 +0530, Sai Krishna Potthuri wrote:
> Added documentation and dt-bindings file which contains MIO pin
> configuration defines for Xilinx ZynqMP pinctrl driver.
>
> Signed-off-by: Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xxxxxxxxxx>
> ---
> .../bindings/pinctrl/xlnx,zynqmp-pinctrl.yaml | 329 ++++++++++++++++++
> include/dt-bindings/pinctrl/pinctrl-zynqmp.h | 29 ++
> 2 files changed, 358 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pinctrl/xlnx,zynqmp-pinctrl.yaml
> create mode 100644 include/dt-bindings/pinctrl/pinctrl-zynqmp.h
>


My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:
./Documentation/devicetree/bindings/pinctrl/xlnx,zynqmp-pinctrl.yaml:254:49: [warning] too few spaces after comma (commas)
./Documentation/devicetree/bindings/pinctrl/xlnx,zynqmp-pinctrl.yaml:278:15: [warning] wrong indentation: expected 12 but found 14 (indentation)

dtschema/dtc warnings/errors:


See https://patchwork.ozlabs.org/patch/1413284

The base for the patch is generally the last rc1. Any dependencies
should be noted.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.