Re: [patch 0/8] ntp/rtc: Fixes and cleanups

From: Thomas Gleixner
Date: Wed Dec 09 2020 - 07:40:20 EST


On Wed, Dec 09 2020 at 05:01, Alexandre Belloni wrote:
> On 09/12/2020 01:33:08+0100, Thomas Gleixner wrote:
>> > The following series addresses the above:
>> >
>> > 1) Fix the readout function of MC146818
>> > 2) Fix the rtc-cmos offset
>> > 3) Reduce the default transport time
>> >
>> > 4) Switch the NTP periodic sync code to a hrtimer/work combo
>> >
>> > 5) Move rtc_set_npt_time() to the ntp code
>> > 6) Make the update offset more intuitive
>> > 7) Simplify the whole machinery
>>
>> any opinion on this?
>>
> This looks very good to me, however, I think the 10ms offset is a bit
> too much.

I pulled it out of thin air TBH. It's at least 50 times more accurate
than what we had before :)

> Do you mind waiting one or two days so I can get my test setup
> back up?

No problem.

Thanks,

tglx