Re: [PATCH] mm,hwpoison: Return -EBUSY when migration fails

From: HORIGUCHI NAOYA(堀口 直也)
Date: Wed Dec 09 2020 - 05:00:03 EST


On Wed, Dec 09, 2020 at 10:28:18AM +0100, Oscar Salvador wrote:
> Currently, we return -EIO when we fail to migrate the page.
>
> Migrations' failures are rather transient as they can happen due to
> several reasons, e.g: high page refcount bump, mapping->migrate_page
> failing etc.
> All meaning that at that time the page could not be migrated, but
> that has nothing to do with an EIO error.
>
> Let us return -EBUSY instead, as we do in case we failed to isolate
> the page.
>
> While are it, let us remove the "ret" print as its value does not change.
>
> Signed-off-by: Oscar Salvador <osalvador@xxxxxxx>

Acked-by: Naoya Horiguchi <naoya.horiguchi@xxxxxxx>