Re: [PATCH net v1 1/2] lan743x: improve performance: fix rx_napi_poll/interrupt ping-pong

From: Sven Van Asbroeck
Date: Tue Dec 08 2020 - 19:18:23 EST


On Tue, Dec 8, 2020 at 6:50 PM Eric Dumazet <edumazet@xxxxxxxxxx> wrote:
>
> Driver could be called with an arbitrary budget (of 64),
> and if its ring buffer has been depleted, return @budget instead of skb counts,
> and not ream the interrupt
>

Aha, so the decision to re-arm the interrupts is made by looking
at whether the device has run out of ring buffers to fill... instead
of checking whether the weight was reached !

That makes complete sense.
Thank you Eric and Jakub for your expert suggestions.